Skip to content

Split render methods#1102

Open
ICaxapI wants to merge 1 commit intoemilyploszaj:1.21from
ICaxapI:1.21_fix_bathcing
Open

Split render methods#1102
ICaxapI wants to merge 1 commit intoemilyploszaj:1.21from
ICaxapI:1.21_fix_bathcing

Conversation

@ICaxapI
Copy link

@ICaxapI ICaxapI commented Dec 29, 2025

Split render methods into renderBase and renderAmount to fix the wrong order in rendering.

Now, in batching renderer enabled and with large trees numbers may render under icons, witch cause the visual bug ->
image

This PR fix this bug ->
image

@emilyploszaj
Copy link
Owner

emilyploszaj commented Feb 21, 2026

This is a bit of an annoying workaround of a problem introduced by other mods. Shown behavior is not present in vanilla. Should this really be in EMI and not resolved elsewhere?

@ICaxapI
Copy link
Author

ICaxapI commented Feb 23, 2026

Это несколько досадное обходное решение проблемы, возникшей из-за других модов. Показанное поведение отсутствует в оригинальной игре. Действительно ли это должно быть реализовано в EMI, а не в других модах?

I could be wrong, but I think the error isn't caused by other mods, but by large trees and internal rendering synchronization issues. Vanilla Minecraft doesn't have crafting trees large enough to reproduce this issue. I just tested this on a pure Minecraft + gregtech + emi setup, and it broke. I also reproduced it on a pure Minecraft + my mod + emi setup, and it caused the issue again. The error only occurs on fairly large trees, but not every time, so I think it's a synchronization issue.

This seems to be a fairly simple fix that follows the original logic without complicating it, while also fixing rendering issues with the EMI recipe tree screen. Honestly, I can't even imagine how this could be fixed using other mods' code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants